Run docker workflow on Astera builder by xraymemory · Pull Request #251 · diff-use/sampleworks

xraymemory · 2026-05-29T18:54:57Z

Summary

run Docker publish jobs on the Astera builder runner so Harbor access stays behind the VPN
use a pinned skopeo container instead of apt-installing skopeo on the runner
remove GitHub-hosted runner disk cleanup steps from self-hosted jobs

Validation

mirrored checkpoint image locally and verified Docker Hub digest matches sha256:ff1dd2b42c3afd593e034cf81df1bf1862c27ae491f46cc10e105629f1102781
git diff --check
parsed .github/workflows/docker.yml with Ruby YAML loader
tested the pinned skopeo inspect command locally

Summary by CodeRabbit

Chores
- Optimized Docker image building workflow with infrastructure improvements to enhance build efficiency and reliability.

coderabbitai · 2026-05-29T18:55:18Z

📝 Walkthrough

Walkthrough

The Docker workflow migrates from ubuntu-latest to Astera runners and containerizes skopeo operations. A pinned SKOPEO_IMAGE replaces direct skopeo installation, and all skopeo invocations (copy and inspect) now run inside the container via docker run. The sync_checkpoints job is reconfigured, while public and astera jobs adopt the new runner and remove disk-space cleanup.

Changes

Docker Workflow Astera Migration

Layer / File(s)	Summary
Containerized skopeo setup and sync_checkpoints job `.github/workflows/docker.yml`	`SKOPEO_IMAGE` environment variable is added to pin a container digest for skopeo operations. The `sync_checkpoints` job switches to `astera-sh-builder` runner while retaining permissions and output wiring.
Skopeo copy and inspect containerization `.github/workflows/docker.yml`	Direct `skopeo copy` and `skopeo inspect` invocations are replaced with `docker run` wrappers that execute skopeo inside the pinned `SKOPEO_IMAGE`, passing Harbor/Docker Hub credentials via environment variables.
Public and astera job runner migration `.github/workflows/docker.yml`	Both `public` and `astera` jobs switch to `astera-sh-builder` runner and remove the "Free disk space" step before checkout, while retaining dependencies, outputs, and subsequent build/push steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

diff-use/sampleworks#244: Directly aligned with this PR's refactoring of the sync_checkpoints job and the public-then-astera image flow to use Astera runners and containerized operations.
diff-use/sampleworks#204: Overlaps in modifying .github/workflows/docker.yml around CI runner and step configuration—Speed up Docker build: free disk space, drop broken cache #204 introduces the "Free disk space" step that this PR removes for the public/astera jobs.

Suggested reviewers

marcuscollins

Poem

🐰 A docker dance on Astera's swift floor,
Where skopeo spins in containers galore,
No disk-space cleanup, just streams that flow free,
Runners aligned, and the workflow's set free! 📦✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Run docker workflow on Astera builder' clearly and concisely summarizes the main change: migrating Docker workflow jobs to run on the Astera builder runner.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/astera-docker-runners

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR updates the Docker publishing GitHub Actions workflow to run on the Astera self-hosted builder (keeping Harbor access behind the VPN) and to execute skopeo via a pinned container image instead of installing it on the runner.

Changes:

Switch Docker publish jobs from ubuntu-latest to the astera-sh-builder self-hosted runner.
Replace runner apt-get install skopeo usage with docker run quay.io/skopeo/stable@sha256:… for skopeo copy and skopeo inspect.
Remove GitHub-hosted runner disk cleanup steps from the self-hosted jobs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

coderabbitai

🧹 Nitpick comments (1)

.github/workflows/docker.yml (1)
118-122: Confirm disk hygiene on the self-hosted Astera runner.

Dropping the GitHub-hosted "Free disk space" step is correct for self-hosted runners (the GitHub-hosted cleanup tricks don't apply). But these jobs build large CUDA-based images and write registry buildcache repeatedly; without periodic pruning the persistent runner's disk can fill over time and start failing builds. Consider a scheduled docker system prune/buildx cache GC on the runner host, or a guarded cleanup step here. The same applies to the astera job (Lines 188-192).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/docker.yml around lines 118 - 122, The workflow currently
omits any disk-pruning for self-hosted runners after large CUDA image builds;
add a guarded cleanup to avoid disk exhaustion by either scheduling host-side
maintenance (e.g., cron job running docker system prune --all --volumes and
buildx cache garbage-collect) or inserting a conditional cleanup step in the
workflow jobs that run heavy builds (refer to the Checkout step and the astera
job) that checks runner type and then runs docker system prune and/or buildx
cache gc with safe flags and confirmation (or a size/age guard) to avoid
removing needed artifacts; ensure the step runs after the build/cache-push
phases and is idempotent and non-destructive for GitHub-hosted runners by gating
on runner labels.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/docker.yml:
- Around line 118-122: The workflow currently omits any disk-pruning for
self-hosted runners after large CUDA image builds; add a guarded cleanup to
avoid disk exhaustion by either scheduling host-side maintenance (e.g., cron job
running docker system prune --all --volumes and buildx cache garbage-collect) or
inserting a conditional cleanup step in the workflow jobs that run heavy builds
(refer to the Checkout step and the astera job) that checks runner type and then
runs docker system prune and/or buildx cache gc with safe flags and confirmation
(or a size/age guard) to avoid removing needed artifacts; ensure the step runs
after the build/cache-push phases and is idempotent and non-destructive for
GitHub-hosted runners by gating on runner labels.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6fef4d47-cea2-41d5-baea-31a99972c178

📥 Commits

Reviewing files that changed from the base of the PR and between f25844f and 48d0517.

📒 Files selected for processing (1)

.github/workflows/docker.yml

chore(ci): run docker workflow on Astera builder

74bf088

Copilot AI review requested due to automatic review settings May 29, 2026 18:54

Copilot started reviewing on behalf of xraymemory May 29, 2026 18:55 View session

Copilot AI reviewed May 29, 2026

View reviewed changes

xraymemory changed the title ~~chore(ci): run docker workflow on Astera builder~~ Run docker workflow on Astera builder May 29, 2026

Merge branch 'main' into chore/astera-docker-runners

48d0517

coderabbitai Bot reviewed Jun 1, 2026

View reviewed changes

manzuoni-astera approved these changes Jun 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run docker workflow on Astera builder#251

Run docker workflow on Astera builder#251
xraymemory wants to merge 2 commits into
mainfrom
chore/astera-docker-runners

xraymemory commented May 29, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 29, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

xraymemory commented May 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xraymemory commented May 29, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 29, 2026 •

edited

Loading